]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
Revert "status/volume: Clear device menus when unsetting stream"
authorFlorian Müllner <fmuellner@gnome.org>
Mon, 12 Dec 2022 17:28:04 +0000 (18:28 +0100)
committerMarge Bot <marge-bot@gnome.org>
Fri, 27 Jan 2023 12:53:33 +0000 (12:53 +0000)
Device additions/removals are tracked by GvcMixerControl, which
doesn't change when unsetting the stream. So clearing the menu
manually was a workaround, not a fix.

It's also worth noting that I failed to reproduce the original
issue again, so it's possible that we were working around a
pipewire bug that has since been fixed.

This reverts commit 1b62b7ea0a8aff38ef8c6873cb8b7651abe24044.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2616>

js/ui/status/volume.js

index 57e179974115ab5bcfd18df095fb804ee9a77cad..bd49cc3ae8a0783103b586a2f39b4840c4ad5dd4 100644 (file)
@@ -83,8 +83,6 @@ const StreamSlider = GObject.registerClass({
             this._connectStream(this._stream);
             this._updateVolume();
         } else {
-            this._deviceSection.removeAll();
-            this._deviceItems.clear();
             this.emit('stream-updated');
         }